diff options
author | Catherine Sullivan <[email protected]> | 2021-05-17 14:08:14 -0700 |
---|---|---|
committer | David S. Miller <[email protected]> | 2021-05-17 15:38:40 -0700 |
commit | f81781835f0adfae8d701545386030d223efcd6f (patch) | |
tree | eb5a3344bb947ff88647919b7964a4c95ad266e4 /tools/perf/scripts/python/syscall-counts.py | |
parent | 5218e919c8d06279884aa0baf76778a6817d5b93 (diff) |
gve: Upgrade memory barrier in poll routine
As currently written, if the driver checks for more work (via
gve_tx_poll or gve_rx_poll) before the device posts work and the
irq doorbell is not unmasked
(via iowrite32be(GVE_IRQ_ACK | GVE_IRQ_EVENT, ...)) before the device
attempts to raise an interrupt, an interrupt is lost and this could
potentially lead to the traffic being completely halted. For
example, if a tx queue has already been stopped, the driver won't get
the chance to complete work and egress will be halted.
We need a full memory barrier in the poll
routine to ensure that the irq doorbell is unmasked before the driver
checks for more work.
Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
Signed-off-by: Catherine Sullivan <[email protected]>
Signed-off-by: David Awogbemila <[email protected]>
Acked-by: Willem de Brujin <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts.py')
0 files changed, 0 insertions, 0 deletions