diff options
| author | Chao Yu <[email protected]> | 2018-08-21 22:49:37 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2018-08-27 19:46:13 +0200 |
| commit | eed276c0401d80b108f5aec018cae7e14b32bc9b (patch) | |
| tree | 221e927bb62311bf10edf316a511fbc595cb5cd3 /tools/perf/scripts/python/syscall-counts.py | |
| parent | d6421a46af70ce8d74f27ee1a099a23b4c90e691 (diff) | |
staging: erofs: fix potential overflow in erofs_grab_bio()
As Dan reported in LKP's mailing list:
https://lists.01.org/pipermail/kbuild-all/2018-August/051419.html
New smatch warnings:
drivers/staging/erofs/internal.h:446 erofs_grab_bio() warn: should 'blkaddr << (12 - 9)' be a 64 bit type?
drivers/staging/erofs/data.c:78 __erofs_get_meta_page() error: 'bio' dereferencing possible ERR_PTR()
drivers/staging/erofs/internal.h:446 erofs_grab_bio() warn: should 'blkaddr << (12 - 9)' be a 64 bit type?
Old smatch warnings:
drivers/staging/erofs/unzip_vle.c:989 z_erofs_vle_unzip() error: double unlock 'mutex:&z_pagemap_global_lock'
drivers/staging/erofs/unzip_vle.c:1318 z_erofs_vle_normalaccess_readpage() warn: should 'page->index << 12' be a 64 bit type?
drivers/staging/erofs/unzip_vle.c:1351 __z_erofs_vle_normalaccess_readpages() warn: should '()->index << 12' be a 64 bit type?
It needs to cast varable's type to sector_t before left shifting.
Reported-by: Dan Carpenter <[email protected]>
Reviewed-by: Gao Xiang <[email protected]>
Signed-off-by: Chao Yu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts.py')
0 files changed, 0 insertions, 0 deletions