diff options
| author | Reinette Chatre <reinette.chatre@intel.com> | 2020-12-17 14:31:20 -0800 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2021-01-11 11:34:45 +0100 |
| commit | e0ad6dc8969f790f14bddcfd7ea284b7e5f88a16 (patch) | |
| tree | d7658d2873bd0500f95dcc975999c0fe00cf6c99 /tools/perf/scripts/python/syscall-counts.py | |
| parent | 3ff4ec0e281d0b234917e6e3033dd3067a5ea945 (diff) | |
x86/resctrl: Use task_curr() instead of task_struct->on_cpu to prevent unnecessary IPI
James reported in [1] that there could be two tasks running on the same CPU
with task_struct->on_cpu set. Using task_struct->on_cpu as a test if a task
is running on a CPU may thus match the old task for a CPU while the
scheduler is running and IPI it unnecessarily.
task_curr() is the correct helper to use. While doing so move the #ifdef
check of the CONFIG_SMP symbol to be a C conditional used to determine
if this helper should be used to ensure the code is always checked for
correctness by the compiler.
[1] https://lore.kernel.org/lkml/a782d2f3-d2f6-795f-f4b1-9462205fd581@arm.com
Reported-by: James Morse <james.morse@arm.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/e9e68ce1441a73401e08b641cc3b9a3cf13fe6d4.1608243147.git.reinette.chatre@intel.com
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts.py')
0 files changed, 0 insertions, 0 deletions