diff options
author | Uwe Kleine-König <[email protected]> | 2023-05-08 16:26:29 +0200 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2023-05-09 19:57:01 -0700 |
commit | c5f3ffe35cc92cce6292b5304409f3edc9281d66 (patch) | |
tree | 3da5f89617fec025e468cab354687926e09f3999 /tools/perf/scripts/python/syscall-counts-by-pid.py | |
parent | b9bc44fe068d6e44504f6f3eb03a325fd6843d60 (diff) |
net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition
The remove callback is only ever called after .probe() returned
successfully. After that get_stmmac_bsp_priv() always return non-NULL.
Side note: The early exit would also be a bug because the return value
of qcom_ethqos_remove() is ignored by the device core and the device is
unbound unconditionally. So exiting early resulted in a dangerous
resource leak as all devm allocated resources (some memory and the
register mappings) are freed but the network device stays around. Using
the network device afterwards probably oopses.
Reviewed-by: Simon Horman <[email protected]>
Signed-off-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Michal Kubiak <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions