diff options
author | Jeff Layton <[email protected]> | 2015-06-03 16:14:25 -0400 |
---|---|---|
committer | Trond Myklebust <[email protected]> | 2015-06-10 18:26:14 -0400 |
commit | 3c87ef6efb40f0e339d705c194b2224f854ec38e (patch) | |
tree | 2878ea261637cf6c85ab69b9cbde70a036b1e3a2 /tools/perf/scripts/python/syscall-counts-by-pid.py | |
parent | 0d2a970d0ae55086520e1e58e572a7acd519429c (diff) |
sunrpc: keep a count of swapfiles associated with the rpc_clnt
Jerome reported seeing a warning pop when working with a swapfile on
NFS. The nfs_swap_activate can end up calling sk_set_memalloc while
holding the rcu_read_lock and that function can sleep.
To fix that, we need to take a reference to the xprt while holding the
rcu_read_lock, set the socket up for swapping and then drop that
reference. But, xprt_put is not exported and having NFS deal with the
underlying xprt is a bit of layering violation anyway.
Fix this by adding a set of activate/deactivate functions that take a
rpc_clnt pointer instead of an rpc_xprt, and have nfs_swap_activate and
nfs_swap_deactivate call those.
Also, add a per-rpc_clnt atomic counter to keep track of the number of
active swapfiles associated with it. When the counter does a 0->1
transition, we enable swapping on the xprt, when we do a 1->0 transition
we disable swapping on it.
This also allows us to be a bit more selective with the RPC_TASK_SWAPPER
flag. If non-swapper and swapper clnts are sharing a xprt, then we only
need to flag the tasks from the swapper clnt with that flag.
Acked-by: Mel Gorman <[email protected]>
Reported-by: Jerome Marchand <[email protected]>
Signed-off-by: Jeff Layton <[email protected]>
Reviewed-by: Chuck Lever <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions