diff options
author | Florian Fainelli <[email protected]> | 2020-05-04 13:18:06 -0700 |
---|---|---|
committer | David S. Miller <[email protected]> | 2020-05-06 17:31:54 -0700 |
commit | 050569fc8384c8056bacefcc246bcb2dfe574936 (patch) | |
tree | 6b4fd984dc23bfc5a0d090b8194db878fc67f8c7 /tools/perf/scripts/python/syscall-counts-by-pid.py | |
parent | 657221598f820ff860972b67583fb91d9ab7caf4 (diff) |
net: dsa: Do not leave DSA master with NULL netdev_ops
When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.
With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.
Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <[email protected]>
Signed-off-by: Florian Fainelli <[email protected]>
Tested-by: Allen Pais <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions