diff options
author | Anton Blanchard <[email protected]> | 2010-05-04 21:19:15 +1000 |
---|---|---|
committer | Arnaldo Carvalho de Melo <[email protected]> | 2010-05-04 10:54:09 -0300 |
commit | 02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e (patch) | |
tree | 4d0c009e30079b127e0d7b01cdd30d8375e44c7c /tools/perf/scripts/python/syscall-counts-by-pid.py | |
parent | 11d232ec285b07860670277c8ab3f6076f7bce1e (diff) |
perf: Fix performance issue with perf report
On a large machine we spend a lot of time in perf_header__find_attr when
running perf report.
If we are parsing a file without PERF_SAMPLE_ID then for each sample we call
perf_header__find_attr and loop through all counter IDs, never finding a match.
As the machine gets larger there are more per cpu counters and we spend an
awful lot of time in there.
The patch below initialises each sample id to -1ULL and checks for this in
perf_header__find_attr. We may need to do something more intelligent eventually
(eg a hash lookup from counter id to attr) but this at least fixes the most
common usage of perf report.
Cc: Peter Zijlstra <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Eric B Munson <[email protected]>
Acked-by: Eric B Munson <[email protected]>
LKML-Reference: <20100504111915.GB14636@kryten>
Signed-off-by: Anton Blanchard <[email protected]>
--
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/syscall-counts-by-pid.py')
0 files changed, 0 insertions, 0 deletions