diff options
author | Dmitry Vyukov <[email protected]> | 2015-09-18 15:54:23 +0200 |
---|---|---|
committer | Thomas Gleixner <[email protected]> | 2015-09-22 15:43:18 +0200 |
commit | 3ed769bdb2a2484fd7f9f7f3047413053aacbe21 (patch) | |
tree | 75f0039968b1b80ffe61b6d446f34ade7b24cf11 /tools/perf/scripts/python/stackcollapse.py | |
parent | 571af55a31d3652ac1f758f116835a76d0335661 (diff) |
timers: Fix data race in timer_stats_account_timer()
timer_stats_account_timer() reads timer->start_site, then checks it
for NULL and then re-reads it again, while
timer_stats_timer_clear_start_info() can concurrently reset
timer->start_site to NULL. This should not lead to crashes, but can
double number of entries in timer stats as start_site is used during
comparison, the doubled entries will have unuseful NULL start_site.
Read timer->start_site only once in timer_stats_account_timer().
The data race was found with KernelThreadSanitizer (KTSAN).
Signed-off-by: Dmitry Vyukov <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions