diff options
| author | Ross Zwisler <[email protected]> | 2016-08-02 14:04:19 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2016-08-02 19:35:08 -0400 |
| commit | a23216a2f1f8a30a3b6588c743681651e4a6aa94 (patch) | |
| tree | 7f8ab6d1d79ef4e48d208faefc7485dd8ca84f75 /tools/perf/scripts/python/sctop.py | |
| parent | a9bfd3321713ecec86282dd2bec04212189f91f1 (diff) | |
radix-tree: fix comment about "exceptional" bits
The bottom two bits of radix tree entries are reserved for special use
by the radix tree code itself. A comment detailing their usage was
added by commit 3bcadd6fa6c4 ("radix-tree: free up the bottom bit of
exceptional entries for reuse")
This comment states that if the bottom two bits are '11', this means
that this is a locked exceptional entry.
It turns out that this bit combination was never actually used. Radix
tree locking for DAX was indeed implemented, but it actually used the
third LSB:
/* We use lowest available exceptional entry bit for locking */
#define RADIX_DAX_ENTRY_LOCK (1 << RADIX_TREE_EXCEPTIONAL_SHIFT)
This locking code was also made specific to the DAX code instead of
being generally implemented in radix-tree.h.
So, fix the comment.
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ross Zwisler <[email protected]>
Reviewed-by: Johannes Thumshirn <[email protected]>
Cc: Dave Chinner <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Konstantin Khlebnikov <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sctop.py')
0 files changed, 0 insertions, 0 deletions