diff options
| author | Lukas Wunner <[email protected]> | 2022-05-12 10:42:03 +0200 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2022-05-13 11:35:46 +0100 |
| commit | 14021da69811cc9bd680a83932614adf308ed0fe (patch) | |
| tree | a33c6518fe9421f9cbf9285844c4bfe040243fff /tools/perf/scripts/python/sctop.py | |
| parent | 3108871f19221372b251f7da1ac38736928b5b3a (diff) | |
usbnet: smsc95xx: Don't reset PHY behind PHY driver's back
smsc95xx_reset() resets the PHY behind the PHY driver's back, which
seems like a bad idea generally. Remove that portion of the function.
We're about to use PHY interrupts instead of polling to detect link
changes on SMSC LAN95xx chips. Because smsc95xx_reset() is called from
usbnet_open(), PHY interrupt settings are lost whenever the net_device
is brought up.
There are two other callers of smsc95xx_reset(), namely smsc95xx_bind()
and smsc95xx_reset_resume(), and both may indeed benefit from a PHY
reset. However they already perform one through their calls to
phy_connect_direct() and phy_init_hw().
Tested-by: Oleksij Rempel <[email protected]> # LAN9514/9512/9500
Tested-by: Ferry Toth <[email protected]> # LAN9514
Signed-off-by: Lukas Wunner <[email protected]>
Cc: Martyn Welch <[email protected]>
Cc: Gabriel Hojda <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sctop.py')
0 files changed, 0 insertions, 0 deletions