diff options
author | Jia-Ju Bai <[email protected]> | 2018-04-11 10:08:18 +0800 |
---|---|---|
committer | Jeff Kirsher <[email protected]> | 2018-04-30 08:12:30 -0700 |
commit | 04a1e08cc734da60445c417e314a0f35a642861b (patch) | |
tree | 609c9e8729f08f574c35d4b1494953eaf8184fe1 /tools/perf/scripts/python/sctop.py | |
parent | 76c2a96d42ca3bdac12c463ff27fec3bb2982e3f (diff) |
i40evf: Replace GFP_ATOMIC with GFP_KERNEL in i40evf_add_vlan
i40evf_add_vlan() is never called in atomic context.
i40evf_add_vlan() is only called by i40evf_vlan_rx_add_vid(),
which is only set as ".ndo_vlan_rx_add_vid" in struct net_device_ops.
".ndo_vlan_rx_add_vid" is not called in atomic context.
Despite never getting called from atomic context,
i40evf_add_vlan() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <[email protected]>
Tested-by: Andrew Bowers <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sctop.py')
0 files changed, 0 insertions, 0 deletions