diff options
| author | Rajneesh Bhardwaj <[email protected]> | 2019-02-01 13:02:26 +0530 |
|---|---|---|
| committer | Andy Shevchenko <[email protected]> | 2019-02-05 20:28:55 +0200 |
| commit | 0e68eeea9894feeba2edf7ec63e4551b87f39621 (patch) | |
| tree | c4ee0d0adb8b6e41b70965ee64dc7a3b6c4599ab /tools/perf/scripts/python/sched-migration.py | |
| parent | e50af8332785355de3cb40d9f5e8c45dbfc86f53 (diff) | |
platform/x86: intel_pmc_core: Fix PCH IP sts reading
A previous commit "platform/x86: intel_pmc_core: Make the driver PCH
family agnostic <c977b98bbef5898ed3d30b08ea67622e9e82082a>" provided
better abstraction to this driver but has some fundamental issues.
e.g. the following condition
for (index = 0; index < pmcdev->map->ppfear_buckets &&
index < PPFEAR_MAX_NUM_ENTRIES; index++, iter++)
is wrong because for CNL, PPFEAR_MAX_NUM_ENTRIES is hardcoded as 5 which
is _wrong_ and even though ppfear_buckets is 8, the loop fails to read
all eight registers needed for CNL PCH i.e. PPFEAR0 and PPFEAR1. This
patch refactors the pfear show logic to correctly read PCH IP power
gating status for Cannonlake and beyond.
Cc: "David E. Box" <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Fixes: c977b98bbef5 ("platform/x86: intel_pmc_core: Make the driver PCH family agnostic")
Signed-off-by: Rajneesh Bhardwaj <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/sched-migration.py')
0 files changed, 0 insertions, 0 deletions