diff options
| author | Jim Cromie <[email protected]> | 2022-09-11 23:28:51 -0600 | 
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-09-24 15:02:02 +0200 | 
| commit | ccc2b496324c13e917ef05f563626f4e7826bef1 (patch) | |
| tree | 7d5a52192327d260911d1566269f7e144fde4709 /tools/perf/scripts/python/powerpc-hcalls.py | |
| parent | 6ce6fae8453687e39e564dc15b6142fe79d76ad5 (diff) | |
drm_print: prefer bare printk KERN_DEBUG on generic fn
drm_print.c calls pr_debug() just once, from __drm_printfn_debug(),
which is a generic/service fn.  The callsite is compile-time enabled
by DEBUG in both DYNAMIC_DEBUG=y/n builds.
For dyndbg builds, reverting this callsite back to bare printk is
correcting a few anti-features:
1- callsite is generic, serves multiple drm users.
   it is soft-wired on currently by #define DEBUG
   could accidentally: #> echo -p > /proc/dynamic_debug/control
2- optional "decorations" by dyndbg are unhelpful/misleading here,
   they describe only the generic site, not end users
IOW, 1,2 are unhelpful at best, and possibly confusing.
reverting yields a nominal data and text shrink:
   text    data     bss     dec     hex filename
 462583   36604   54592 553779   87333 /kernel/drivers/gpu/drm/drm.ko
 462515   36532   54592 553639   872a7 -dirty/kernel/drivers/gpu/drm/drm.ko
Signed-off-by: Jim Cromie <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/powerpc-hcalls.py')
0 files changed, 0 insertions, 0 deletions