diff options
| author | Fabio Aiuto <[email protected]> | 2021-07-30 15:40:48 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2021-07-30 16:06:32 +0200 |
| commit | 658dfbec96620ff08ef17c87b35b6a6bb8d52fc0 (patch) | |
| tree | b6ed1c77a4f4c86ad170e8a06d8048e6fedf66de /tools/perf/scripts/python/netdev-times.py | |
| parent | d8062f6adca1ef13a0bab70ddcd67881d483338e (diff) | |
staging: rtl8723bs: remove unused BIT macros definitions
BIT(x) macro used all over the driver is defined in
include/vsdo/bit.h as
- #define BIT(nr) (UL(1) << (nr))
which is safer than the local BIT macros declared.
Local macros shift a signed integer which brings
unespected results. For example:
(unsigned long)(1 << 31) => 0xffffffff80000000
shift.c:
int main() {
printf("%lx\n", (unsigned long)(1 << 31));
printf("%lx\n", (unsigned long)(1U << 31));
return 0;
}
...
$ ./shift
ffffffff80000000
80000000
...
So just remove redundant, less safe macro declarations.
Suggested-by: David Sterba <[email protected]>
Signed-off-by: Fabio Aiuto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/netdev-times.py')
0 files changed, 0 insertions, 0 deletions