diff options
| author | Frank Schaefer <[email protected]> | 2012-12-08 11:31:29 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2012-12-22 20:55:01 -0200 |
| commit | 4078d625c9610a362f571f7e5ff2521adadfff2b (patch) | |
| tree | b3fa9a55bf32243b13eff3cb939cdeec971f17ba /tools/perf/scripts/python/netdev-times.py | |
| parent | a48370158d134807f5b02655287b91cc000c45ca (diff) | |
[media] em28xx: move caching of pointer to vmalloc memory in videobuf to struct em28xx_buffer
In the current code em28xx_urb_data_copy() caches the pointer to the vmalloc
memory in videobuf locally.
The alternative would be to call videobuf_to_vmalloc() for each processed USB
data packet (isoc USB transfers => 64 times per URB) in the em28xx_copy_*()
functions.
With the next commits, the data processing code will be split into functions
for serveral reasons:
- em28xx_urb_data_copy() is generally way to long, making it less readable
- there is code duplication between VBI and video data processing
- support for em25xx data processing (uses a different header and frame
end signaling mechanism) will be added
This would require extensive usage of pointer-pointers, which usually makes the
code less readable and prone to bugs.
The better solution is to cache the pointer in struct em28xx_buffer.
This also improves consistency, because we already track the buffer fill count there.
Signed-off-by: Frank Schäfer <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/netdev-times.py')
0 files changed, 0 insertions, 0 deletions