diff options
author | Jim Cromie <[email protected]> | 2011-05-23 12:44:55 -0600 |
---|---|---|
committer | Michal Marek <[email protected]> | 2011-05-24 16:07:07 +0200 |
commit | de7b0b4110795be914e6cafdfec4276b2618cc78 (patch) | |
tree | 7800d8bc7778229004a95e1599a334095d8c4d43 /tools/perf/scripts/python/net_dropmonitor.py | |
parent | 2ee2d29289951b4cb7578d75f199e4aa4084fe6f (diff) |
export_report: do collectcfiles work in perl itself
Avoid spawning a shell pipeline doing cat, grep, sed, and do it all
inside perl. The <*.c> globbing construct works at least as far back
as 5.8.9
Note that this is not just an optimization; the sed command
in the pipeline was unterminated, due to lack of escape on the
end-of-line (\$) in the regex, resulting in this:
$ perl ../linux-2.6/scripts/export_report.pl > /dev/null
sed: -e expression #1, char 5: unterminated `s' command
sh: .mod.c/: not found
Comments on an earlier patch sought an all-perl implementation.
Signed-off-by: Jim Cromie <[email protected]>
cc: Michal Marek <[email protected]>,
cc: [email protected]
cc: Arnaud Lacombe [email protected]
cc: Stephen Hemminger [email protected]
Signed-off-by: Michal Marek <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/net_dropmonitor.py')
0 files changed, 0 insertions, 0 deletions