aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/net_dropmonitor.py
diff options
context:
space:
mode:
authorAndrey Smirnov <[email protected]>2019-06-18 22:27:06 -0700
committerAndrzej Hajda <[email protected]>2019-06-27 13:37:31 +0200
commit6d0c38315915d49fbbcc55340c06f811a55a4885 (patch)
tree37af3d00ab0ee604404fe42ab7bb584c48d39432 /tools/perf/scripts/python/net_dropmonitor.py
parent3f072c304c0a7e1045ef2e5478403c0137746878 (diff)
drm/bridge: tc358767: Drop custom tc_write()/tc_read() accessors
A very unfortunate aspect of tc_write()/tc_read() macro helpers is that they capture quite a bit of context around them and thus require the caller to have magic variables 'ret' and 'tc' as well as label 'err'. That makes a number of code paths rather counter-intuitive and somewhat clunky, for example tc_stream_clock_calc() ends up being like this: int ret; tc_write(DP0_VIDMNGEN1, 32768); return 0; err: return ret; which is rather surprising when you read the code for the first time. Since those helpers arguably aren't really saving that much code and there's no way of fixing them without making them too verbose to be worth it change the driver code to not use them at all. Signed-off-by: Andrey Smirnov <[email protected]> Reviewed-by: Andrzej Hajda <[email protected]> Reviewed-by: Tomi Valkeinen <[email protected]> Cc: Andrzej Hajda <[email protected]> Cc: Laurent Pinchart <[email protected]> Cc: Tomi Valkeinen <[email protected]> Cc: Andrey Gusakov <[email protected]> Cc: Philipp Zabel <[email protected]> Cc: Cory Tusar <[email protected]> Cc: Chris Healy <[email protected]> Cc: Lucas Stach <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Andrzej Hajda <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/net_dropmonitor.py')
0 files changed, 0 insertions, 0 deletions