aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/net_dropmonitor.py
diff options
context:
space:
mode:
authorSrivatsa S. Bhat <[email protected]>2014-03-11 02:12:27 +0530
committerRafael J. Wysocki <[email protected]>2014-03-20 13:43:48 +0100
commit0be94bad0b601df94b8558c0cbd28f7e6633c9e8 (patch)
tree21dab481dd764a7b18d6671c1f79f7dcbf552b20 /tools/perf/scripts/python/net_dropmonitor.py
parentc270a817196a9374a2dc730624d1501dced40b4d (diff)
mm, vmstat: Fix CPU hotplug callback registration
Subsystems that want to register CPU hotplug callbacks, as well as perform initialization for the CPUs that are already online, often do it as shown below: get_online_cpus(); for_each_online_cpu(cpu) init_cpu(cpu); register_cpu_notifier(&foobar_cpu_notifier); put_online_cpus(); This is wrong, since it is prone to ABBA deadlocks involving the cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently with CPU hotplug operations). Instead, the correct and race-free way of performing the callback registration is: cpu_notifier_register_begin(); for_each_online_cpu(cpu) init_cpu(cpu); /* Note the use of the double underscored version of the API */ __register_cpu_notifier(&foobar_cpu_notifier); cpu_notifier_register_done(); Fix the vmstat code in the MM subsystem by using this latter form of callback registration. Cc: Andrew Morton <[email protected]> Cc: Johannes Weiner <[email protected]> Cc: Cody P Schafer <[email protected]> Cc: Toshi Kani <[email protected]> Cc: Dave Hansen <[email protected]> Cc: Ingo Molnar <[email protected]> Acked-by: Christoph Lameter <[email protected]> Acked-by: Rik van Riel <[email protected]> Reviewed-by: Yasuaki Ishimatsu <[email protected]> Signed-off-by: Srivatsa S. Bhat <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/net_dropmonitor.py')
0 files changed, 0 insertions, 0 deletions