diff options
author | Justin Stitt <[email protected]> | 2023-08-23 00:23:08 +0000 |
---|---|---|
committer | Oded Gabbay <[email protected]> | 2023-10-09 12:37:20 +0300 |
commit | 571bfeb48ac24564658e58c0a3a5318904846aae (patch) | |
tree | 87518f975f0e482a5f9985fe9791e069c2025880 /tools/perf/scripts/python/gecko.py | |
parent | 90f3de616259cbb5666f00f8daf5420cd7d71d18 (diff) |
accel/habanalabs: refactor deprecated strncpy
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy`!
There is likely no bug happening in this case since HL_STR_MAX is
strictly larger than all source strings. Nonetheless, prefer a safer and
more robust interface.
It should also be noted that `strscpy` will not pad like `strncpy`. If
this NUL-padding behavior is _required_ we should use `strscpy_pad`
instead of `strscpy`.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: [email protected]
Signed-off-by: Justin Stitt <[email protected]>
Reviewed-by: Stanislaw Gruszka <[email protected]>
Reviewed-by: Oded Gabbay <[email protected]>
Signed-off-by: Oded Gabbay <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/gecko.py')
0 files changed, 0 insertions, 0 deletions