diff options
author | Vincent Donnefort <[email protected]> | 2021-02-16 10:35:06 +0000 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2021-03-06 12:40:22 +0100 |
commit | 453e41085183980087f8a80dada523caf1131c3c (patch) | |
tree | ed5794ec1ec3186b9525d3f7737a008a5f3fe645 /tools/perf/scripts/python/flamegraph.py | |
parent | 62f250694092dd5fef9900dc3126f07110bf9d48 (diff) |
cpu/hotplug: Add cpuhp_invoke_callback_range()
Factorizing and unifying cpuhp callback range invocations, especially for
the hotunplug path, where two different ways of decrementing were used. The
first one, decrements before the callback is called:
cpuhp_thread_fun()
state = st->state;
st->state--;
cpuhp_invoke_callback(state);
The second one, after:
take_down_cpu()|cpuhp_down_callbacks()
cpuhp_invoke_callback(st->state);
st->state--;
This is problematic for rolling back the steps in case of error, as
depending on the decrement, the rollback will start from N or N-1. It also
makes tracing inconsistent, between steps run in the cpuhp thread and
the others.
Additionally, avoid useless cpuhp_thread_fun() loops by skipping empty
steps.
Signed-off-by: Vincent Donnefort <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/flamegraph.py')
0 files changed, 0 insertions, 0 deletions