diff options
author | Nathan Chancellor <natechancellor@gmail.com> | 2020-05-16 01:08:06 -0700 |
---|---|---|
committer | Stephen Boyd <sboyd@kernel.org> | 2020-05-26 16:33:37 -0700 |
commit | f376c43bec4f8ee8d1ba5c5c4cfbd6e84fb279cb (patch) | |
tree | e65a7d980bd6235effe4446ccb2d0ea9d00a9e4b /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 8f3d9f354286745c751374f5f1fcafee6b3f3136 (diff) |
clk: bcm2835: Fix return type of bcm2835_register_gate
bcm2835_register_gate is used as a callback for the clk_register member
of bcm2835_clk_desc, which expects a struct clk_hw * return type but
bcm2835_register_gate returns a struct clk *.
This discrepancy is hidden by the fact that bcm2835_register_gate is
cast to the typedef bcm2835_clk_register by the _REGISTER macro. This
turns out to be a control flow integrity violation, which is how this
was noticed.
Change the return type of bcm2835_register_gate to be struct clk_hw *
and use clk_hw_register_gate to do so. This should be a non-functional
change as clk_register_gate calls clk_hw_register_gate anyways but this
is needed to avoid issues with further changes.
Fixes: b19f009d4510 ("clk: bcm2835: Migrate to clk_hw based registration and OF APIs")
Link: https://github.com/ClangBuiltLinux/linux/issues/1028
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lkml.kernel.org/r/20200516080806.1459784-1-natechancellor@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions