diff options
author | Douglas Anderson <[email protected]> | 2020-12-14 09:21:15 -0800 |
---|---|---|
committer | Ulf Hansson <[email protected]> | 2021-02-01 11:54:43 +0100 |
commit | f16c8fd4449efb4441272af6102e55523b15a7ad (patch) | |
tree | b836f62bd53c2e9bdc1376e595d6fc9e52ce5099 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | a8cd989e1a57dff3994cd113650afb0223c44ec6 (diff) |
mmc: sdhci-msm: Actually set the actual clock
The MSM SDHCI driver always set the "actual_clock" field to 0. It had
a comment about it not being needed because we weren't using the
standard SDHCI divider mechanism and we'd just fallback to
"host->clock". However, it's still better to provide the actual
clock. Why?
1. It will make timeout calculations slightly better. On one system I
have, the eMMC requets 200 MHz (for HS400-ES) but actually gets 192
MHz. These are close, but why not get the more accurate one.
2. If things are seriously off in the clock driver and it's missing
rates or picking the wrong rate (maybe it's rounding up instead of
down), this will make it much more obvious what's going on.
NOTE: we have to be a little careful here because the "actual_clock"
field shouldn't include the multiplier that sdhci-msm needs
internally.
Suggested-by: Adrian Hunter <[email protected]>
Signed-off-by: Douglas Anderson <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Acked-by: Adrian Hunter <[email protected]>
Reviewed-by: Veerabhadrarao Badiganti <[email protected]>
Link: https://lore.kernel.org/r/20201214092048.v5.2.I7564620993acd4baa63fa0e3925ca879a86d3ee3@changeid
Signed-off-by: Ulf Hansson <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions