diff options
| author | Andy Shevchenko <[email protected]> | 2020-02-03 15:31:28 +0200 |
|---|---|---|
| committer | Petr Mladek <[email protected]> | 2020-02-11 10:44:12 +0100 |
| commit | bb72e3981d8e7bb80db7cebc57a4e10769a509c9 (patch) | |
| tree | d4e2a35e6c92d586f67efa6b23cedcb81e90d554 /tools/perf/scripts/python/exported-sql-viewer.py | |
| parent | d58ad10122e6f8f84b1ef60227233b7c5de2bc02 (diff) | |
console: Avoid positive return code from unregister_console()
There are only two callers that use the returned code from
unregister_console():
- unregister_early_console() in arch/m68k/kernel/early_printk.c
- kgdb_unregister_nmi_console() in drivers/tty/serial/kgdb_nmi.c
They both expect to get "0" on success and a non-zero value on error.
But the current behavior is confusing and buggy:
- _braille_unregister_console() returns "1" on success
- unregister_console() returns "1" on error
Fix and clean up the behavior:
- Return success when _braille_unregister_console() succeeded
- Return a meaningful error code when the console was
not registered before
Link: http://lkml.kernel.org/r/[email protected]
To: [email protected]
To: Steven Rostedt <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Reviewed-by: Sergey Senozhatsky <[email protected]>
Signed-off-by: Petr Mladek <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions