diff options
author | Nick Alcock <[email protected]> | 2023-02-16 15:24:04 +0000 |
---|---|---|
committer | Bjorn Helgaas <[email protected]> | 2023-02-17 08:47:58 -0600 |
commit | f98954b293d0a0f9646117af75c82c1b89191c53 (patch) | |
tree | f85cb016a73518dcf8ab28ea81edf64ad7f202c0 /tools/perf/scripts/python/export-to-sqlite.py | |
parent | 1b929c02afd37871d5afb9d498426f83432e71c2 (diff) |
PCI: Remove MODULE_LICENSE so boolean drivers don't look like modules
Since 8b41fc4454e3 ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are
used to identify modules. As a consequence, MODULE_LICENSE in non-modules
causes modprobe to misidentify the object file as a module when it is not,
and modprobe might succeed rather than failing with a suitable error
message.
For tristate modules that can be either built-in or loaded at runtime,
modprobe succeeds in both cases:
# modprobe ext4
[exit status zero if CONFIG_EXT4_FS=y or =m]
For boolean modules like the Standard Hot Plug Controller driver (shpchp)
that cannot be loaded at runtime, modprobe should always fail like this:
# modprobe shpchp
modprobe: FATAL: Module shpchp not found in directory /lib/modules/...
[exit status non-zero regardless of CONFIG_HOTPLUG_PCI_SHPC]
but prior to this commit, shpchp_core.c contained MODULE_LICENSE, so
"modprobe shpchp" silently succeeded when it should have failed.
Remove MODULE_LICENSE in files that cannot be built as modules.
[bhelgaas: commit log, squash]
Suggested-by: Luis Chamberlain <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Nick Alcock <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: Hitomi Hasegawa <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions