diff options
author | Hans de Goede <[email protected]> | 2023-05-10 18:22:31 +0200 |
---|---|---|
committer | Lee Jones <[email protected]> | 2023-05-25 12:16:27 +0100 |
commit | e298d8a38b2341865f9feb04591aabb109e8bb13 (patch) | |
tree | f713d72e63db8f85c61635ca0cce46741fffa98a /tools/perf/scripts/python/export-to-sqlite.py | |
parent | d9ff8a8eecf8ad70aadc54cce39208b3957f2c6a (diff) |
leds: Change led_trigger_blink[_oneshot]() delay parameters to pass-by-value
led_blink_set[_oneshot]()'s delay_on and delay_off function parameters
are pass by reference, so that hw-blink implementations can report
back the actual achieved delays when the values have been rounded
to something the hw supports.
This is really only interesting for the sysfs API / the timer trigger.
Other triggers don't really care about this and none of the callers of
led_trigger_blink[_oneshot]() do anything with the returned delay values.
Change the led_trigger_blink[_oneshot]() delay parameters to pass-by-value,
there are 2 reasons for this:
1. led_cdev->blink_set() may sleep, while led_trigger_blink() may not.
So on hw where led_cdev->blink_set() sleeps the call needs to be deferred
to a workqueue, in which case the actual achieved delays are unknown
(this is a preparation patch for the deferring).
2. Since the callers don't care about the actual achieved delays, allowing
callers to directly pass a value leads to simpler code for most callers.
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Jacek Anaszewski <[email protected]>
Tested-by: Yauhen Kharuzhy <[email protected]>
Acked-by: Greg Kroah-Hartman <[email protected]>
Acked-by: Sebastian Reichel <[email protected]>
Acked-by: Florian Westphal <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions