aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/export-to-sqlite.py
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2022-08-25 16:13:34 +0200
committerHans de Goede <hdegoede@redhat.com>2022-08-26 12:59:01 +0200
commit83ac7a1c2ed5f17caa07cbbc84bad3c05dc3bf22 (patch)
tree29e2b564377c1c9ec179a9128c3fcd0620d308f3 /tools/perf/scripts/python/export-to-sqlite.py
parent6485f72b515690bdbebc711755af096d1dc08ce2 (diff)
platform/x86: msi-laptop: Fix old-ec check for backlight registering
Commit 2cc6c717799f ("msi-laptop: Port to new backlight interface selection API") replaced this check: if (!quirks->old_ec_model || acpi_video_backlight_support()) pr_info("Brightness ignored, ..."); else do_register(); With: if (quirks->old_ec_model || acpi_video_get_backlight_type() == acpi_backlight_vendor) do_register(); But since the do_register() part was part of the else branch, the entire condition should be inverted. So not only the 2 statements on either side of the || should be inverted, but the || itself should be replaced with a &&. In practice this has likely not been an issue because the new-ec models (old_ec_model==false) likely all support ACPI video backlight control, making acpi_video_get_backlight_type() return acpi_backlight_video turning the second part of the || also false when old_ec_model == false. Fixes: 2cc6c717799f ("msi-laptop: Port to new backlight interface selection API") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20220825141336.208597-1-hdegoede@redhat.com
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions