diff options
| author | Michael Walle <[email protected]> | 2020-04-03 19:49:42 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-04-16 16:12:34 +0200 |
| commit | 810bc0a5fafb8575b9406fcc8b0be77ff93a7be0 (patch) | |
| tree | c9e604703b4f973dc039d6f7a282800d173375b3 /tools/perf/scripts/python/export-to-sqlite.py | |
| parent | 5745fd0f950f1ac99c7c680245353a961da3ca14 (diff) | |
tty: serial: fsl_lpuart: make coverity happy
Coverity reports the following:
var_compare_op: Comparing chan to null implies that chan might be null.
1234 if (chan)
1235 dmaengine_terminate_all(chan);
1236
Dereference after null check (FORWARD_NULL)
var_deref_op: Dereferencing null pointer chan.
1237 dma_unmap_sg(chan->device->dev, &sport->rx_sgl, 1, DMA_FROM_DEVICE);
Technically, this is correct. But lpuart_dma_rx_free() is guarded by
lpuart_dma_rx_use which is only true if there is a dma channel, see
lpuart_rx_dma_startup(). In any way, this looks bogus. So remove
the superfluous "if (chan)" check and make coverity happy.
Fixes: a092ab25fdaa ("tty: serial: fsl_lpuart: fix DMA mapping")
Signed-off-by: Michael Walle <[email protected]>
Reported-by: Colin Ian King <[email protected]>
Acked-by: Jiri Slaby <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions