diff options
| author | Baochen Qiang <[email protected]> | 2024-06-11 09:42:33 +0300 |
|---|---|---|
| committer | Kalle Valo <[email protected]> | 2024-06-11 21:36:57 +0300 |
| commit | 53d7c99719e29819eaeb9f373d262a6b56ea7cce (patch) | |
| tree | d89054edb35e3faa69e3102afe946dbdfa8c3059 /tools/perf/scripts/python/export-to-sqlite.py | |
| parent | 8b2a12749b08726f006303814ecc1c37024d3617 (diff) | |
wifi: ath11k: fix RCU documentation in ath11k_mac_op_ipv6_changed()
Current documentation on RCU in ath11k_mac_op_ipv6_changed() says:
/* Note: read_lock_bh() calls rcu_read_lock() */
read_lock_bh(&idev->lock);
This is wrong because without enabling CONFIG_PREEMPT_RT
rcu_read_lock() is not called by read_lock_bh(). The reason
why current code works even in a CONFIG_PREEMPT_RT=n kernel
is because atomic_notifier_call_chain() already does that for
us, see:
int atomic_notifier_call_chain()
{
...
rcu_read_lock();
ret = notifier_call_chain(&nh->head, val, v, -1, NULL);
rcu_read_unlock();
...
}
and backtrace:
ath11k_mac_op_ipv6_changed
ieee80211_ifa6_changed
notifier_call_chain
atomic_notifier_call_chain
So update the comment to make it correct.
This is found during code review, compile tested only.
Fixes: feafe59c8975 ("wifi: ath11k: use RCU when accessing struct inet6_dev::ac_list")
Signed-off-by: Baochen Qiang <[email protected]>
Acked-by: Jeff Johnson <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://msgid.link/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions