diff options
| author | Dave Gordon <[email protected]> | 2016-07-20 18:16:07 +0100 |
|---|---|---|
| committer | Chris Wilson <[email protected]> | 2016-07-21 09:59:46 +0100 |
| commit | f8ca0c07f68ba47f9c512019514af2922713b5ce (patch) | |
| tree | b803925ac9450548d77c2fbbd24b07dc20f1f1e1 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | 38a0f2db5b776246da35fe83c96f2c1ba87e4afa (diff) | |
drm/i915: rename & update eb_select_ring()
'ring' is an old deprecated term for a GPU engine, so we're trying to
phase out all such terminology. eb_select_ring() not only has 'ring'
(meaning engine) in its name, but it has an ugly calling convention
whereby it returns an errno and stores a pointer-to-engine indirectly
through an output parameter. As there is only one error it ever returns
(-EINVAL), we can make it return the pointer directly, and have the
caller pass back the error code -EINVAL if the pointer result is NULL.
Thus we can replace
- ret = eb_select_ring(dev_priv, file, args, &engine);
- if (ret)
- return ret;
with
+ engine = eb_select_engine(dev_priv, file, args);
+ if (!engine)
+ return -EINVAL;
for increased clarity and maybe save a few cycles too.
Signed-off-by: Dave Gordon <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Chris Wilson <[email protected]>
Signed-off-by: Chris Wilson <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions