diff options
| author | Halil Pasic <[email protected]> | 2020-02-13 13:37:27 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <[email protected]> | 2020-03-08 05:35:24 -0400 |
| commit | f5f6b95c72f7f8bb46eace8c5306c752d0133daa (patch) | |
| tree | bee578f0cdc2d74c420259a8b362dcb6ad17dc20 /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | f13f09a12cbd0c7b776e083c5d008b6c6a9c4e0b (diff) | |
virtio-blk: fix hw_queue stopped on arbitrary error
Since nobody else is going to restart our hw_queue for us, the
blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient
necessarily sufficient to ensure that the queue will get started again.
In case of global resource outage (-ENOMEM because mapping failure,
because of swiotlb full) our virtqueue may be empty and we can get
stuck with a stopped hw_queue.
Let us not stop the queue on arbitrary errors, but only on -EONSPC which
indicates a full virtqueue, where the hw_queue is guaranteed to get
started by virtblk_done() before when it makes sense to carry on
submitting requests. Let us also remove a stale comment.
Signed-off-by: Halil Pasic <[email protected]>
Cc: Jens Axboe <[email protected]>
Fixes: f7728002c1c7 ("virtio_ring: fix return code on DMA mapping fails")
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions