diff options
author | Dave Hansen <[email protected]> | 2014-11-11 14:01:33 -0800 |
---|---|---|
committer | Thomas Gleixner <[email protected]> | 2014-11-16 12:13:16 +0100 |
commit | 2cd3949f702692cf4c5d05b463f19cd706a92dd3 (patch) | |
tree | 43142a52795b60abcb84bcbad1031bdc27eaf53d /tools/perf/scripts/python/export-to-postgresql.py | |
parent | 0cafa3e714fa34af100c575ada31d52caea20957 (diff) |
x86: Require exact match for 'noxsave' command line option
We have some very similarly named command-line options:
arch/x86/kernel/cpu/common.c:__setup("noxsave", x86_xsave_setup);
arch/x86/kernel/cpu/common.c:__setup("noxsaveopt", x86_xsaveopt_setup);
arch/x86/kernel/cpu/common.c:__setup("noxsaves", x86_xsaves_setup);
__setup() is designed to match options that take arguments, like
"foo=bar" where you would have:
__setup("foo", x86_foo_func...);
The problem is that "noxsave" actually _matches_ "noxsaves" in
the same way that "foo" matches "foo=bar". If you boot an old
kernel that does not know about "noxsaves" with "noxsaves" on the
command line, it will interpret the argument as "noxsave", which
is not what you want at all.
This makes the "noxsave" handler only return success when it finds
an *exact* match.
[ tglx: We really need to make __setup() more robust. ]
Signed-off-by: Dave Hansen <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Fenghua Yu <[email protected]>
Cc: [email protected]
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions