diff options
author | Nick Desaulniers <[email protected]> | 2023-09-15 10:34:28 -0700 |
---|---|---|
committer | Alexei Starovoitov <[email protected]> | 2023-09-15 12:08:27 -0700 |
commit | c0bb9fb0e52a64601d38b3739b729d9138d4c8a1 (patch) | |
tree | 3bcdbab6f955b0a3a3d22296743703c70588b6a0 /tools/perf/scripts/python/event_analyzing_sample.py | |
parent | 8f908db77782630c45ba29dac35c434b5ce0b730 (diff) |
bpf: Fix BTF_ID symbol generation collision in tools/
Marcus and Satya reported an issue where BTF_ID macro generates same
symbol in separate objects and that breaks final vmlinux link.
ld.lld: error: ld-temp.o <inline asm>:14577:1: symbol
'__BTF_ID__struct__cgroup__624' is already defined
This can be triggered under specific configs when __COUNTER__ happens to
be the same for the same symbol in two different translation units,
which is already quite unlikely to happen.
Add __LINE__ number suffix to make BTF_ID symbol more unique, which is
not a complete fix, but it would help for now and meanwhile we can work
on better solution as suggested by Andrii.
Cc: [email protected]
Reported-by: Satya Durga Srinivasu Prabhala <[email protected]>
Reported-by: Marcus Seyfarth <[email protected]>
Closes: https://github.com/ClangBuiltLinux/linux/issues/1913
Debugged-by: Nathan Chancellor <[email protected]>
Co-developed-by: Jiri Olsa <[email protected]>
Link: https://lore.kernel.org/bpf/CAEf4Bzb5KQ2_LmhN769ifMeSJaWfebccUasQOfQKaOd0nQ51tw@mail.gmail.com/
Signed-off-by: Nick Desaulniers <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexei Starovoitov <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions