diff options
author | Jakub Kicinski <[email protected]> | 2023-10-20 15:18:27 -0700 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2023-10-23 10:15:36 -0700 |
commit | c0119e62b2fe990a512a5ab8fb7c30e28fa619b8 (patch) | |
tree | 33ca9c6fc080539e9a41fab164b62c85927c3cd8 /tools/perf/scripts/python/event_analyzing_sample.py | |
parent | b7c4f5730a9fa258c8e79f6387a03f3a95c681a2 (diff) |
tools: ynl-gen: change spacing around __attribute__
checkpatch gets confused and treats __attribute__ as a function call.
It complains about white space before "(":
WARNING:SPACING: space prohibited between function name and open parenthesis '('
+ struct netdev_queue_get_rsp obj __attribute__ ((aligned (8)));
No spaces wins in the kernel:
$ git grep 'attribute__((.*aligned(' | wc -l
480
$ git grep 'attribute__ ((.*aligned (' | wc -l
110
$ git grep 'attribute__ ((.*aligned(' | wc -l
94
$ git grep 'attribute__((.*aligned (' | wc -l
63
So, whatever, change the codegen.
Note that checkpatch also thinks we should use __aligned(),
but this is user space code.
Link: https://lore.kernel.org/all/[email protected]/
Acked-by: Stanislav Fomichev <[email protected]>
Reviewed-by: Amritha Nambiar <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions