diff options
author | NeilBrown <[email protected]> | 2017-06-18 14:38:58 +1000 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2017-06-18 12:40:59 -0600 |
commit | 8cb0defbaa8d4778c7474677cbb93d8cd602a2a6 (patch) | |
tree | 370c172503752131603c2e9f00a902143ebefe9c /tools/perf/scripts/python/event_analyzing_sample.py | |
parent | f856dc36b6db4cbe757f95787136087fb37af2af (diff) |
drbd: use bio_clone_fast() instead of bio_clone()
drbd does not modify the bi_io_vec of the cloned bio,
so there is no need to clone that part. So bio_clone_fast()
is the better choice.
For bio_clone_fast() we need to specify a bio_set.
We could use fs_bio_set, which bio_clone() uses, or
drbd_md_io_bio_set, which drbd uses for metadata, but it is
generally best to avoid sharing bio_sets unless you can
be certain that there are no interdependencies.
So create a new bio_set, drbd_io_bio_set, and use bio_clone_fast().
Also remove a "XXX cannot fail ???" comment because it definitely
cannot fail - bio_clone_fast() doesn't fail if the GFP flags allow for
sleeping.
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions