diff options
author | Xin Long <lucien.xin@gmail.com> | 2018-11-18 15:07:38 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-11-19 12:39:05 -0800 |
commit | 02968ccf0125d39b08ecef5946300a8a873c0942 (patch) | |
tree | ce9c31025aa5c8c06708ac3c527a1a8ea4ff4d0a /tools/perf/scripts/python/event_analyzing_sample.py | |
parent | a36b5444b1ec79ed5fedd12295626c05b4f788eb (diff) |
sctp: count sk_wmem_alloc by skb truesize in sctp_packet_transmit
Now sctp increases sk_wmem_alloc by 1 when doing set_owner_w for the
skb allocked in sctp_packet_transmit and decreases by 1 when freeing
this skb.
But when this skb goes through networking stack, some subcomponents
might change skb->truesize and add the same amount on sk_wmem_alloc.
However sctp doesn't know the amount to decrease by, it would cause
a leak on sk->sk_wmem_alloc and the sock can never be freed.
Xiumei found this issue when it hit esp_output_head() by using sctp
over ipsec, where skb->truesize is added and so is sk->sk_wmem_alloc.
Since sctp has used sk_wmem_queued to count for writable space since
Commit cd305c74b0f8 ("sctp: use sk_wmem_queued to check for writable
space"), it's ok to fix it by counting sk_wmem_alloc by skb truesize
in sctp_packet_transmit.
Fixes: cac2661c53f3 ("esp4: Avoid skb_cow_data whenever possible")
Reported-by: Xiumei Mu <xmu@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/perf/scripts/python/event_analyzing_sample.py')
0 files changed, 0 insertions, 0 deletions