aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/check-perf-trace.py
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <[email protected]>2014-10-14 15:07:48 -0300
committerArnaldo Carvalho de Melo <[email protected]>2014-10-14 17:50:44 -0300
commite167f995e26249aa93708589c5eea539652351fa (patch)
tree2115967fe7043ee4ed58fe6a58991fd029ea91d3 /tools/perf/scripts/python/check-perf-trace.py
parent8885846fc4b708f543fe1dd3ef7402417d2d4151 (diff)
perf machine: Add missing dsos->root rbtree root initialization
A segfault happens on 'perf test hists_link' because we end up using a struct machines on the stack, and then machines__init() was not initializing the newly introduced rb_root, just the existing list_head. When we introduced struct dsos, to group the two ways to store dsos, i.e. the linked list and the rbtree, we didn't turned the initialization done in: machines__init(machines->host) -> machine__init() -> INIT_LIST_HEAD into a dsos__init() to keep on initializing the list_head but _as well_ initializing the rb_root, oops. All worked because outside perf-test we probably zalloc the whole thing which ends up initializing it in to NULL. So the problem looks contained to 'perf test' that uses it on stack, etc. Reported-by: Jiri Olsa <[email protected]> Acked-by: Waiman Long <[email protected]>, Cc: Adrian Hunter <[email protected]>, Cc: Don Zickus <[email protected]> Cc: Douglas Hatch <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Scott J Norton <[email protected]> Cc: Waiman Long <[email protected]>, Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions