diff options
| author | Russell King - ARM Linux <[email protected]> | 2011-01-03 22:31:04 +0000 |
|---|---|---|
| committer | Dan Williams <[email protected]> | 2011-01-04 19:16:10 -0800 |
| commit | 91aa5fadb831e7b6ea473a526a6b49c6dc4819ce (patch) | |
| tree | 4f96e2649b8725b6f58bace588e90c9f38c3dc80 /tools/perf/scripts/python/check-perf-trace.py | |
| parent | 4440aacf3a171a0ab498feda58d100a320c5d9ff (diff) | |
ARM: PL08x: fix atomic_t usage and tx_submit() return value range
The last_issued variable uses an atomic type, which is only
incremented inside a protected region, and then read. Everywhere else
only reads the value, so it isn't using atomic_t correctly, and it
doesn't even need to. Moreover, the DMA engine code provides us with
a variable for this already - chan.cookie. Use chan.cookie instead.
Also, avoid negative dma_cookie_t values - negative returns from
tx_submit() mean failure, yet in reality we always succeed. Restart
from cookie 1, just like other DMA engine drivers do.
Signed-off-by: Russell King <[email protected]>
Acked-by: Linus Walleij <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions