diff options
author | Fabio Estevam <[email protected]> | 2020-08-19 19:02:19 -0300 |
---|---|---|
committer | Shawn Guo <[email protected]> | 2020-08-30 19:58:50 +0800 |
commit | 843b993c2d0b5e9aa22965234b914625ed3d3713 (patch) | |
tree | d5e089ef4500caf6f00b5dcee440555b36ad06fe /tools/perf/scripts/python/check-perf-trace.py | |
parent | bcf7206fe9c35e048e1dc90cf62216b0f5eaf091 (diff) |
arm64: dts: imx8m: Fix the SPI chipselect polarity
The conversion of the spi-imx driver to use GPIO descriptors
in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors")
helped to detect the following SPI chipselect polarity mismatch on an
imx6q-sabresd for example:
[ 4.854337] m25p80@0 enforce active low on chipselect handle
Prior to the above commit, the chipselect polarity passed via cs-gpios
property was ignored and considered active-low.
The reason for such mismatch is clearly explained in the comments inside
drivers/gpio/gpiolib-of.c:
* SPI children have active low chip selects
* by default. This can be specified negatively
* by just omitting "spi-cs-high" in the
* device node, or actively by tagging on
* GPIO_ACTIVE_LOW as flag in the device
* tree. If the line is simultaneously
* tagged as active low in the device tree
* and has the "spi-cs-high" set, we get a
* conflict and the "spi-cs-high" flag will
* take precedence.
To properly represent the SPI chipselect polarity, change it to active-low
when the "spi-cs-high" property is absent.
Signed-off-by: Fabio Estevam <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions