aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/check-perf-trace.py
diff options
context:
space:
mode:
authorGuenter Roeck <[email protected]>2022-03-18 09:54:22 -0700
committerTzung-Bi Shih <[email protected]>2022-04-19 11:27:20 +0800
commit57b888ca2541785de2fcb90575b378921919b6c0 (patch)
tree62f89684a583d15507faef4ef5e6e17666ecbd3d /tools/perf/scripts/python/check-perf-trace.py
parent8d4668064cce8f8d52d4bd2b3b864feed33b1258 (diff)
platform/chrome: Re-introduce cros_ec_cmd_xfer and use it for ioctls
Commit 413dda8f2c6f ("platform/chrome: cros_ec_chardev: Use cros_ec_cmd_xfer_status helper") inadvertendly changed the userspace ABI. Previously, cros_ec ioctls would only report errors if the EC communication failed, and otherwise return success and the result of the EC communication. An EC command execution failure was reported in the EC response field. The above mentioned commit changed this behavior, and the ioctl itself would fail. This breaks userspace commands trying to analyze the EC command execution error since the actual EC command response is no longer reported to userspace. Fix the problem by re-introducing the cros_ec_cmd_xfer() helper, and use it to handle ioctl messages. Fixes: 413dda8f2c6f ("platform/chrome: cros_ec_chardev: Use cros_ec_cmd_xfer_status helper") Cc: Daisuke Nojiri <[email protected]> Cc: Rob Barnes <[email protected]> Cc: Rajat Jain <[email protected]> Cc: Brian Norris <[email protected]> Cc: Parth Malkan <[email protected]> Reviewed-by: Daisuke Nojiri <[email protected]> Reviewed-by: Brian Norris <[email protected]> Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Tzung-Bi Shih <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions