diff options
author | Chris Wilson <[email protected]> | 2019-05-07 13:11:07 +0100 |
---|---|---|
committer | Chris Wilson <[email protected]> | 2019-05-07 17:40:19 +0100 |
commit | 1830374e1332c93f65399687b72ff55ca4d8c978 (patch) | |
tree | 8a27e5a7c46cdd38ce4ff1f01b072fa81e815dfd /tools/perf/scripts/python/check-perf-trace.py | |
parent | ae2306315fe83ba2523d557a8fe472d7c587c1ca (diff) |
drm/i915: Cancel retire_worker on parking
Replace the racy continuation check within retire_work with a definite
kill-switch on idling. The race was being exposed by gem_concurrent_blit
where the retire_worker would be terminated too early leaving us
spinning in debugfs/i915_drop_caches with nothing flushing the
retirement queue.
Although that the igt is trying to idle from one child while submitting
from another may be a contributing factor as to why it runs so slowly...
v2: Use the non-sync version of cancel_delayed_work(), we only need to
stop it from being scheduled as we independently check whether now is
the right time to be parking.
Testcase: igt/gem_concurrent_blit
Fixes: 79ffac8599c4 ("drm/i915: Invert the GEM wakeref hierarchy")
Signed-off-by: Chris Wilson <[email protected]>
Cc: Tvrtko Ursulin <[email protected]>
Reviewed-by: Tvrtko Ursulin <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/check-perf-trace.py')
0 files changed, 0 insertions, 0 deletions