diff options
| author | Jiri Olsa <[email protected]> | 2020-05-20 09:40:50 +0200 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <[email protected]> | 2020-05-28 10:03:27 -0300 |
| commit | ae7626418d71ae551fd1f0a85ae7ad9d8b2d4f28 (patch) | |
| tree | 14080aa52983c9b7689b840a4293ea44c7adc207 /tools/perf/scripts/python/bin/stackcollapse-report | |
| parent | 498ef715a00bb87ca65a89e7893c644499bb309c (diff) | |
perf stat: Fail on extra comma while parsing events
Ian reported that we allow to parse following:
$ perf stat -e ,cycles true
which is wrong and we should fail, like we do with this fix:
$ perf stat -e ,cycles true
event syntax error: ',cycles'
\___ parser error
The reason is that we don't have rule for ',' in 'event' start condition
and it's matched and accepted by default rule.
Add scanner debug support (that Ian already added for expr code),
which was really useful for finding this. It's enabled together with
bison debug via 'make PARSER_DEBUG=1'.
Reported-by: Ian Rogers <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
Acked-by: Ian Rogers <[email protected]>
Tested-by: Arnaldo Carvalho de Melo <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Michael Petlan <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions