diff options
| author | Jani Nikula <[email protected]> | 2018-10-16 15:29:37 +0300 |
|---|---|---|
| committer | Jani Nikula <[email protected]> | 2018-10-17 09:55:21 +0300 |
| commit | 7b3e51dd439bead71d9e4504d89a32a8496ac0aa (patch) | |
| tree | df8baa3f474dc96de2c37c8e5f5460d3d0c28970 /tools/perf/scripts/python/bin/stackcollapse-report | |
| parent | 046c9bca3d829d1f67e4667ffeac099564a683a4 (diff) | |
drm/i915: Ensure _print_param() builds with Clang
When building the kernel with Clang with defconfig and CONFIG_64BIT
disabled, vmlinux fails to link because of the BUILD_BUG in
_print_param.
ld: drivers/gpu/drm/i915/i915_params.o: in function `i915_params_dump':
i915_params.c:(.text+0x56): undefined reference to
`__compiletime_assert_191'
This function is semantically invalid unless the code is first inlined
then constant folded, which doesn't work for Clang because semantic
analysis happens before optimization/inlining.
[The above written by Nathan Chancellor <[email protected]>]
Use WARN_ONCE() instead of BUILD_BUG() to avoid the problem. The
WARN_ONCE() should get optimized away unless there's a type that's not
handled by _print_param().
References: https://github.com/ClangBuiltLinux/linux/issues/191
References: http://mid.mail-archive.com/[email protected]
Cc: Nick Desaulniers <[email protected]>
Cc: Nathan Chancellor <[email protected]>
Cc: Chris Wilson <[email protected]>
Reported-by: Nick Desaulniers <[email protected]>
Reported-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions