aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/bin/stackcollapse-report
diff options
context:
space:
mode:
authorDan Carpenter <[email protected]>2018-08-31 09:20:18 -0400
committerMauro Carvalho Chehab <[email protected]>2018-09-17 15:19:10 -0400
commit75b090a5bc961e578e232269596ddd0486ec6fca (patch)
tree826f0d73751046629f1d6a95a075ff921e7424bd /tools/perf/scripts/python/bin/stackcollapse-report
parent7d3073f13ea85a1e8b868502fa6735696a629060 (diff)
media: sr030pc30: remove NULL in sr030pc30_base_config()
This code doesn't check for NULL consistently and it generates a Smatch warning: drivers/media/i2c/sr030pc30.c:575 sr030pc30_base_config() error: we previously assumed 'info->pdata' could be null (see line 572) Fortunately, "info->pdata" can't be NULL to that check can be removed. The other thing is that if "ret" is an error code here, then we don't want to do the next call to cam_i2c_write(), so actually let's flip that test around and return the error. This is more of a theoretical issue than something which is likely to affect real life. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Sakari Ailus <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions