aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/bin/stackcollapse-report
diff options
context:
space:
mode:
authorTetsuo Handa <[email protected]>2020-08-21 17:27:19 +0900
committerKalle Valo <[email protected]>2020-08-27 12:59:49 +0300
commit621a3a8b1c0ecf16e1e5667ea5756a76a082b738 (patch)
treeabcbd1c228bb3612a2842b7484a909d31c490974 /tools/perf/scripts/python/bin/stackcollapse-report
parent32f447304da1f342c01651406e3064aa550eb513 (diff)
mwifiex: don't call del_timer_sync() on uninitialized timer
syzbot is reporting that del_timer_sync() is called from mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without checking timer_setup() from mwifiex_usb_tx_init() was called [1]. Ganapathi Bhat proposed a possibly cleaner fix, but it seems that that fix was forgotten [2]. "grep -FrB1 'del_timer' drivers/ | grep -FA1 '.function)'" says that currently there are 28 locations which call del_timer[_sync]() only if that timer's function field was initialized (because timer_setup() sets that timer's function field). Therefore, let's use same approach here. [1] https://syzkaller.appspot.com/bug?id=26525f643f454dd7be0078423e3cdb0d57744959 [2] https://lkml.kernel.org/r/CA+ASDXMHt2gq9Hy+iP_BYkWXsSreWdp3_bAfMkNcuqJ3K+-jbQ@mail.gmail.com Reported-by: syzbot <[email protected]> Cc: Ganapathi Bhat <[email protected]> Cc: Brian Norris <[email protected]> Signed-off-by: Tetsuo Handa <[email protected]> Reviewed-by: Brian Norris <[email protected]> Acked-by: Ganapathi Bhat <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-report')
0 files changed, 0 insertions, 0 deletions