diff options
| author | Fabio M. De Francesco <[email protected]> | 2022-04-25 19:57:54 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-04-26 12:51:31 +0200 |
| commit | e88a6a8fece9b92be4f55735134a022061e6e68b (patch) | |
| tree | ddadbbdf7e9e41c963927058f1fe1513d90c852e /tools/perf/scripts/python/bin/stackcollapse-record | |
| parent | 1d625960e41907af706f573a3cd097595a0ade63 (diff) | |
binder: Use memcpy_{to,from}_page() in binder_alloc_do_buffer_copy()
The use of kmap_atomic() is being deprecated in favor of kmap_local_page()
where it is feasible. Each call of kmap_atomic() in the kernel creates
a non-preemptible section and disable pagefaults. This could be a source
of unwanted latency, so kmap_local_page() should be preferred.
With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible. Furthermore, the mapping can be acquired from any context
(including interrupts). binder_alloc_do_buffer_copy() is a function where
the use of kmap_local_page() in place of kmap_atomic() is correctly suited.
Use kmap_local_page() / kunmap_local() in place of kmap_atomic() /
kunmap_atomic() but, instead of open coding the mappings and call memcpy()
to and from the virtual addresses of the mapped pages, prefer the use of
the memcpy_{to,from}_page() wrappers (as suggested by Christophe
Jaillet).
Cc: Christophe JAILLET <[email protected]>
Acked-by: Todd Kjos <[email protected]>
Signed-off-by: Fabio M. De Francesco <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/stackcollapse-record')
0 files changed, 0 insertions, 0 deletions