aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/bin/export-to-postgresql-report
diff options
context:
space:
mode:
authorDavid Howells <[email protected]>2020-04-28 21:27:48 +0100
committerLinus Torvalds <[email protected]>2020-04-28 14:37:40 -0700
commitdd7bc8158b413e0b580c491e8bd18cb91057c7c2 (patch)
treec50f4a1e9fc7769c7f5c6b7bf0d4b1ab7085bf18 /tools/perf/scripts/python/bin/export-to-postgresql-report
parentedb98d162418e90d6d2c1cec42e09be0375cfd88 (diff)
Fix use after free in get_tree_bdev()
Commit 6fcf0c72e4b9, a fix to get_tree_bdev() put a missing blkdev_put() in the wrong place, before a warnf() that displays the bdev under consideration rather after it. This results in a silent lockup in printk("%pg") called via warnf() from get_tree_bdev() under some circumstances when there's a race with the blockdev being frozen. This can be caused by xfstests/tests/generic/085 in combination with Lukas Czerner's ext4 mount API conversion patchset. It looks like it ought to occur with other users of get_tree_bdev() such as XFS, but apparently doesn't. Fix this by switching the order of the lines. Fixes: 6fcf0c72e4b9 ("vfs: add missing blkdev_put() in get_tree_bdev()") Reported-by: Lukas Czerner <[email protected]> Signed-off-by: David Howells <[email protected]> cc: Ian Kent <[email protected]> cc: Al Viro <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/export-to-postgresql-report')
0 files changed, 0 insertions, 0 deletions