diff options
author | Keith Busch <[email protected]> | 2020-05-08 13:04:06 -0700 |
---|---|---|
committer | Christoph Hellwig <[email protected]> | 2020-05-12 18:02:24 +0200 |
commit | b69e2ef24b7b4867f80f47e2781e95d0bacd15cb (patch) | |
tree | 849b398f5ec603aa97bc6a1f6e387bfa90a7ba82 /tools/perf/scripts/python/bin/export-to-postgresql-report | |
parent | 59c7c3caaaf8750df4ec3255082f15eb4e371514 (diff) |
nvme-pci: dma read memory barrier for completions
Control dependencies do not guarantee load order across the condition,
allowing a CPU to predict and speculate memory reads.
Commit 324b494c2862 inlined verifying a new completion with its
handling. At least one architecture was observed to access the contents
out of order, resulting in the driver using stale data for the
completion.
Add a dma read barrier before reading the completion queue entry and
after the condition its contents depend on to ensure the read order is
determinsitic.
Reported-by: John Garry <[email protected]>
Suggested-by: Will Deacon <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
Tested-by: John Garry <[email protected]>
Acked-by: Will Deacon <[email protected]>
Reviewed-by: Sagi Grimberg <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/export-to-postgresql-report')
0 files changed, 0 insertions, 0 deletions