aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/bin/event_analyzing_sample-report
diff options
context:
space:
mode:
authorStanislaw Gruszka <[email protected]>2014-11-11 14:28:47 +0100
committerJohn W. Linville <[email protected]>2014-11-11 16:12:44 -0500
commitcfd9167af14eb4ec21517a32911d460083ee3d59 (patch)
treeb2ff80f7c9a79d42473ccbbb6fbe6d93615fe182 /tools/perf/scripts/python/bin/event_analyzing_sample-report
parent9d828ad7d3c791d45a2eb1c6c683bd86ba04713b (diff)
rt2x00: do not align payload on modern H/W
RT2800 and newer hardware require padding between header and payload if header length is not multiple of 4. For historical reasons we also align payload to to 4 bytes boundary, but such alignment is not needed on modern H/W. Patch fixes skb_under_panic problems reported from time to time: https://bugzilla.kernel.org/show_bug.cgi?id=84911 https://bugzilla.kernel.org/show_bug.cgi?id=72471 http://marc.info/?l=linux-wireless&m=139108549530402&w=2 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1087591 Panic happened because we eat 4 bytes of skb headroom on each (re)transmission when sending frame without the payload and the header length not being multiple of 4 (i.e. QoS header has 26 bytes). On such case because paylad_aling=2 is bigger than header_align=0 we increase header_align by 4 bytes. To prevent that we could change the check to: if (payload_length && payload_align > header_align) header_align += 4; but not aligning payload at all is more effective and alignment is not really needed by H/W (that has been tested on OpenWrt project for few years now). Reported-and-tested-by: Antti S. Lankila <[email protected]> Debugged-by: Antti S. Lankila <[email protected]> Reported-by: Henrik Asp <[email protected]> Originally-From: Helmut Schaa <[email protected]> Cc: [email protected] Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: John W. Linville <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/bin/event_analyzing_sample-report')
0 files changed, 0 insertions, 0 deletions