aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/arm-cs-trace-disasm.py
diff options
context:
space:
mode:
authorBarry Song <[email protected]>2024-09-05 20:11:24 +1200
committerWill Deacon <[email protected]>2024-09-06 12:28:33 +0100
commit70565f2be8807e5ea24dfb421197b881a02af5e2 (patch)
tree64c06e769a98c7376c062e62b12ec882b2089fd1 /tools/perf/scripts/python/arm-cs-trace-disasm.py
parenteeb8fdfcf0901578c26ecfb11e814f36bc9a92f5 (diff)
mm: arm64: document why pte is not advanced in contpte_ptep_set_access_flags()
According to David and Ryan, there isn't a bug here, even though we don't advance the PTE entry, because __ptep_set_access_flags() only uses the access flags from the entry. However, we always check pte_same(pte, entry) using the first entry in __ptep_set_access_flags(). This means that the checks from 1 to nr - 1 are not comparing the same PTE indexes (thus, they always return false), which can be a bit confusing. To clarify the code, let's add some comments. Reviewed-by: Ryan Roberts <[email protected]> Signed-off-by: Barry Song <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: John Hubbard <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: Will Deacon <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/arm-cs-trace-disasm.py')
0 files changed, 0 insertions, 0 deletions