diff options
author | Namhyung Kim <[email protected]> | 2024-10-15 23:23:55 -0700 |
---|---|---|
committer | Namhyung Kim <[email protected]> | 2024-10-22 09:52:11 -0700 |
commit | 3b193a57baf15c468e4f86cebc694ca4fe18301b (patch) | |
tree | 1576c1659129f4bda60d230ea153f4485ede6806 /tools/perf/scripts/python/arm-cs-trace-disasm.py | |
parent | 88bc63d00eb6defb661b9fd79957660b4dfa4b50 (diff) |
perf tools: Detect missing kernel features properly
The evsel__detect_missing_features() is to check if the attributes of
the evsel is supported or not. But it checks the attribute based on the
given evsel, it might miss something if the attr doesn't have the bit or
give incorrect results if the event is special.
Also it maintains the order of the feature that was added to the kernel
which means it can assume older features should be supported once it
detects the current feature is working. To minimized the confusion and
to accurately check the kernel features, I think it's better to use a
software event and go through all the features at once.
Also make the function static since it's only used in evsel.c.
Reviewed-by: James Clark <[email protected]>
Reviewed-by: Ravi Bangoria <[email protected]>
Acked-by: Kan Liang <[email protected]>
Cc: James Clark <[email protected]>
Cc: Atish Patra <[email protected]>
Cc: Mingwei Zhang <[email protected]>
Cc: Kajol Jain <[email protected]>
Cc: Thomas Richter <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/arm-cs-trace-disasm.py')
0 files changed, 0 insertions, 0 deletions